Fix false positive when v1 recipe name is non-context variable #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip checking v1 recipe name if it contains unresolved variables,
in order to fix false positives when a variable
from `conda_build_config.yaml` is used.
Iterating over all possible variants and verifying the resulting package
names is unlikely to be worth the extra complexity. This also roughly
matches the linter behavior for v0 recipes, where `{{ var_name }}` is
converted into `var_name`, and therefore is never properly linted
anyway.
Fixes conda-forge#2224
beckermr
requested changes
Feb 25, 2025
By "complexity", I meant the coding effort to make that happen. Are you suggesting we re-lint the recipe for all variants, or just special-case the package name? I suppose the former could make sense, though we'd probably need to filter out duplicates somehow, and that probably isn't going to be easy. |
|
Package name but ok. I'm not going to stand in the way here. |
beckermr
approved these changes
Feb 25, 2025
|
Thanks. I mean, if you insist I can look into doing it, but it feels a bit, well, inefficient, to call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)Fixes #2224
Skip checking v1 recipe name if it contains unresolved variables, in order to fix false positives when a variable
from
conda_build_config.yamlis used.Iterating over all possible variants and verifying the resulting package names is unlikely to be worth the extra complexity. This also roughly matches the linter behavior for v0 recipes, where
{{ var_name }}is converted intovar_name, and therefore is never properly linted anyway.