Support running conda-smithy lint in feedstock directory
#2250
+168
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the default behavior of `conda-smithy lint` to detect
if a feedstock directory has been passed in place of the recipe
directory (e.g. by running it with no paths specified), and handle
the paths appropriately.
The new logic covers three possible scenarios:
1. If `--feedstock-directory` is passed, everything works as before.
2. If not, the specified directory is checked for `meta.yaml`
and `recipe.yaml`, also as before.
3. If neither exists, the specified directory is checked for
`conda-forge.yml`. If it exists, it set to be the feedstock
directory, and the file is parsed to determine the correct recipe
subdirectory.
This is primarily meant to address my common mistake of running:
conda smithy lint
in the feedstock directory, which can lead to pretty confusing error
messages, particularly if the feedstock is using v1 recipes, and smithy
says it can't find `recipe/meta.yaml` -- and you start wondering whether
you've made a typo in `conda-forge.yml` or what.
This is an alternative to conda-forge#2249.
|
@jaimergp, could you tell me what you think of this? I've moved the logic into a function, so I could add tests for it later. |
This was referenced Feb 26, 2025
beckermr
reviewed
Feb 26, 2025
|
Sure. Just tested against staged-recipes 29285 and both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)Fixes #2225
Extend the default behavior of
conda-smithy lintto detect if a feedstock directory has been passed in place of the recipe directory (e.g. by running it with no paths specified), and handle the paths appropriately.The new logic covers three possible scenarios:
If
--feedstock-directoryis passed, everything works as before.If not, the specified directory is checked for
meta.yamlandrecipe.yaml, also as before.If neither exists, the specified directory is checked for
conda-forge.yml. If it exists, it set to be the feedstock directory, and the file is parsed to determine the correct recipe subdirectory.This is primarily meant to address my common mistake of running:
in the feedstock directory, which can lead to pretty confusing error messages, particularly if the feedstock is using v1 recipes, and smithy says it can't find
recipe/meta.yaml-- and you start wondering whether you've made a typo inconda-forge.ymlor what.This is an alternative to #2249.