Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove '--with-looptools' support #10

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Feb 23, 2025

  • Remove '--with-looptools' support during build.
  • Add guards to ensure looptools.hh is not distributed in include/ninja and include/quadninja.
    • This should be reverted in the future when the issue is fixed.
  • Bump build number.

Forward port of PR #9

* Remove '--with-looptools' support during build.
   - As there are issues with ninja-hep-ph-static use in mg5amcnlo when build with
     '--with-looptools' remove this option until it can be properly debugged later.
   - c.f. https://github.com/conda-forge/mg5amcnlo-feedstock/issues/3
   - Revert parts of PR https://github.com/conda-forge/ninja-hep-ph-feedstock/pull/7.
* Add guards to ensure looptools.hh is not distributed in include/ninja and include/quadninja.
   - This should be reverted in the future when the issue is fixed.
* Bump build number.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@matthewfeickert matthewfeickert self-assigned this Feb 23, 2025
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 23, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13485731739. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13480557344. Examine the logs at this URL for more detail.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13485639224. Examine the logs at this URL for more detail.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Feb 23, 2025

* Remove '--with-looptools' support during build.
   - As there are issues with ninja-hep-ph-static use in mg5amcnlo when build with
     '--with-looptools' remove this option until it can be properly debugged later.
   - c.f. https://github.com/conda-forge/mg5amcnlo-feedstock/issues/ 3
   - Revert parts of PR https://github.com/conda-forge/ninja-hep-ph-feedstock/pull/ 7.
* Add guards to ensure looptools.hh is not distributed in include/ninja and include/quadninja.
   - This should be reverted in the future when the issue is fixed.
* Bump build number.
@matthewfeickert matthewfeickert marked this pull request as ready for review February 23, 2025 18:38
@matthewfeickert matthewfeickert merged commit 6bbd7e8 into conda-forge:main Feb 23, 2025
8 checks passed
@matthewfeickert matthewfeickert deleted the fix/remove-looptools branch February 23, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants