Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 0.5.1. Add build for linux-aarch64 #21

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Update to 0.5.1. Add build for linux-aarch64 #21

wants to merge 12 commits into from

Conversation

martin-g
Copy link

@martin-g martin-g commented Feb 12, 2025 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@martin-g
Add builds for linux-aarch64 and osx-arm64
5fb9897 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g requested a review from yihming as a code owner February 12, 2025 09:35
@martin-g
Copy link
Author

@conda-forge-admin, please rerender

@martin-g martin-g mentioned this pull request Feb 12, 2025
Open
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 12, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

For recipe/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package scikit-misc using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13282505290. Examine the logs at this URL for more detail.

conda-forge-webservices[bot] and others added 3 commits February 12, 2025 09:38
MNT: Re-rendered with conda-build 25.1.1, conda-smithy 3.45.4, and co…
a4ba295 
…nda-forge-pinning 2025.02.12.08.02.13
@martin-g
Update to 0.5.1
06450c8 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Fix linter issues: add stdlib(c) and add setuptools
c36c075 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@martin-g
Copy link
Author

@conda-forge-admin, please rerender

martin-g
martin-g commented Feb 12, 2025
View reviewed changes
martin-g and others added 2 commits February 12, 2025 12:51
@martin-g
Replace setuptools with mesonpy
8f38dc5
@martin-g
Set lower version of Python to 3.10
32f9fb2 
```
Found ninja-1.12.1 at /home/conda/feedstock_root/build_artifacts/scikit-misc_1739357624709/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/bin/ninja
2025-02-12T10:56:29.5761313Z
2025-02-12T10:56:29.5761817Z   meson-python: error: The package requires Python version >=3.10, running on 3.9.21
2025-02-12T10:56:29.5762204Z   error: subprocess-exited-with-error
```

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 12, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13284082921. Examine the logs at this URL for more detail.

@martin-g
Copy link
Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 3 commits February 12, 2025 11:14
MNT: Re-rendered with conda-build 25.1.1, conda-smithy 3.45.4, and co…
be831d1 
…nda-forge-pinning 2025.02.12.10.21.35
@martin-g
Use skip to set Python min to 3.10
94802ed 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Do not build osx-arm64
f88c5d7 
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@martin-g
Copy link
Author

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/scikit-misc and so here I am doing that.

@martin-g martin-g changed the title Add builds for linux-aarch64 and osx-arm64 Add build for linux-aarch64 Feb 12, 2025
@martin-g martin-g changed the title Add build for linux-aarch64 Update to 0.5.1. Add build for linux-aarch64 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihming yihming Awaiting requested review from yihming yihming is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-g @conda-forge-admin