-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ocpsvg #27391
Add ocpsvg #27391
Conversation
This package is called cadquery-ocp externally, as it includes OCP in the python dependency.
Some of the dependencies of this package don't pass pip check themselves
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/ocpsvg/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/ocpsvg/yum_requirements.txt
Outdated
@@ -0,0 +1 @@ | |||
mesa-libGLU-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really necessary? can you show me the errors without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is that we've started to remove these from other builds:
conda-forge/qt-main-feedstock#287
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import: 'ocpsvg'
Traceback (most recent call last):
File "/home/conda/staged-recipes/build_artifacts/ocpsvg_1724522226129/test_tmp/run_test.py", line 2, in <module>
import ocpsvg
File "/home/conda/staged-recipes/build_artifacts/ocpsvg_1724522226129/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/ocpsvg/__init__.py", line 1, in <module>
from .svg import (
File "/home/conda/staged-recipes/build_artifacts/ocpsvg_1724522226129/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.12/site-packages/ocpsvg/svg.py", line 22, in <module>
from OCP.BRepAdaptor import BRepAdaptor_Curve
ImportError: libGL.so.1: cannot open shared object file: No such file or directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[gestures towards failed tests]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other mechanism I know about to deal with things like GL are the CDT packages; which I believe is to compile against things that should be present at runtime; but running the tests effectively are runtime, hence needed.
Maybe I only need to add the runtime here; mesa-glu-devel is how I’ve seen it solved before, perhaps I need to be more targeted in just picking up the runtime? I think I was under the impression there was a small allowlist of things that can go here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets see what happens with:
This caused the import tests to fail before, but 🤷
Otherwise, I think this is ready - thank you - shall I ping or will you merge it directly? |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).