Add `intervalues` #29110

apcamargo · 2025-02-12T19:24:20Z

This PR adds intervalues, by @debruijn.

Checklist

github-actions · 2025-02-12T19:25:46Z

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

conda-forge-admin · 2025-02-12T19:26:08Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/intervalues/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/intervalues/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
- For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
- For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13293232867. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-02-12T19:35:44Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/intervalues/meta.yaml) and found some lint.

Here's what I've got...

For recipes/intervalues/meta.yaml:

❌ This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

For recipes/intervalues/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
- For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
- For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13293389182. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-02-12T19:54:03Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/intervalues/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/intervalues/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13295504901. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-02-12T23:03:43Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/intervalues/meta.yaml) and found some lint.

Here's what I've got...

For recipes/intervalues/meta.yaml:

❌ Non noarch packages should have python requirement without any version constraints.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13296581188. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-02-12T23:10:56Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/intervalues/meta.yaml) and found it was in an excellent condition.

conda-forge-admin · 2025-02-13T00:02:27Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/intervalues/meta.yaml) and found some lint.

Here's what I've got...

For recipes/intervalues/meta.yaml:

❌ Non noarch packages should have python requirement without any version constraints.
❌ Non noarch packages should have python requirement without any version constraints.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13297312532. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-02-13T00:06:55Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/intervalues/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/intervalues/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
- For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13320107750. Examine the logs at this URL for more detail.}

apcamargo · 2025-02-13T00:12:19Z

@conda-forge/help-python The Linux test is failing because of a OverLinkingError. Any idea what could be happening here?

Packaging intervalues
Packaging intervalues-0.3.0-py312he4ac13c_0
compiling .pyc files...
number of files: 29
Warning: rpath /home/conda/staged-recipes/build_artifacts/intervalues_1739401996777/_build_env/lib is outside prefix /home/conda/staged-recipes/build_artifacts/intervalues_1739401996777/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold (removing it)
   INFO: sysroot: '/home/conda/staged-recipes/build_artifacts/intervalues_1739401996777/_build_env/x86_64-conda-linux-gnu/sysroot/' files: '['usr/share/zoneinfo', 'usr/share/locale/zh_TW/LC_MESSAGES/libc.mo', 'usr/share/locale/zh_CN/LC_MESSAGES/libc.mo', 'usr/share/locale/vi/LC_MESSAGES/libc.mo']'
  ERROR (intervalues,lib/python3.12/site-packages/intervalues_pyrust.cpython-312-x86_64-linux-gnu.so): Needed DSO lib/libgcc_s.so.1 found in ['conda-forge/linux-64::libgcc==14.2.0=h77fa898_1']
  ERROR (intervalues,lib/python3.12/site-packages/intervalues_pyrust.cpython-312-x86_64-linux-gnu.so): .. but ['conda-forge/linux-64::libgcc==14.2.0=h77fa898_1'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
   INFO (intervalues,lib/python3.12/site-packages/intervalues_pyrust.cpython-312-x86_64-linux-gnu.so): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/librt.so.1 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h0157908_18
   INFO (intervalues,lib/python3.12/site-packages/intervalues_pyrust.cpython-312-x86_64-linux-gnu.so): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/libpthread.so.0 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h0157908_18
   INFO (intervalues,lib/python3.12/site-packages/intervalues_pyrust.cpython-312-x86_64-linux-gnu.so): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/libm.so.6 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h0157908_18
   INFO (intervalues,lib/python3.12/site-packages/intervalues_pyrust.cpython-312-x86_64-linux-gnu.so): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/libdl.so.2 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h0157908_18
   INFO (intervalues,lib/python3.12/site-packages/intervalues_pyrust.cpython-312-x86_64-linux-gnu.so): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/libc.so.6 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h0157908_18
   INFO (intervalues,lib/python3.12/site-packages/intervalues_pyrust.cpython-312-x86_64-linux-gnu.so): Needed DSO x86_64-conda-linux-gnu/sysroot/lib64/ld-linux-x86-64.so.2 found in CDT/compiler package conda-forge/noarch::sysroot_linux-64==2.17=h0157908_18
WARNING (intervalues): interpreter (Python) package conda-forge/linux-64::python==3.12.8=h9e4cc4f_1_cpython in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
Traceback (most recent call last):
  File "/home/conda/staged-recipes-copy/.ci_support/build_all.py", line 356, in <module>
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/post.py", line 1566, in check_overlinking_impl
    raise OverLinkingError(overlinking_errors)
conda_build.exceptions.OverLinkingError: <exception str() failed>

ocefpaf · 2025-02-13T11:22:18Z

You may have thirdpaty license in the rust package. Can you use cargo bundle license here? See https://github.com/conda-forge/staged-recipes/pull/28803/files for an example.

apcamargo · 2025-02-13T20:32:03Z

Done, @ocefpaf

~~The OverLinkingError persists, tough. I couldn't find anything about it in the documentation.~~

Update: Adding libgcc as a runtime requirement in Linux fixed the issue.

conda-forge-admin · 2025-02-14T00:59:26Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/intervalues/meta.yaml) and found some lint.

Here's what I've got...

For recipes/intervalues/meta.yaml:

❌ Non noarch packages should have python requirement without any version constraints.
❌ Non noarch packages should have python requirement without any version constraints.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13320302597. Examine the logs at this URL for more detail.}

apcamargo · 2025-02-14T01:26:36Z

@conda-forge/help-python, ready for review. The builds and tests seem to be all fine.

The linter is complaining that non-noarch recipes should not have version constraints for Python. However, this library has set the minimum version to 3.10 in the source code and the CI fails when it tries to build for Python 3.9. Not sure what is the proper thing to do in a case like this.

recipes/intervalues/meta.yaml

conda-forge-admin · 2025-02-14T08:13:03Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/intervalues/meta.yaml) and found it was in an excellent condition.

apcamargo · 2025-02-14T09:41:26Z

Thanks, @ocefpaf!

Add intervalues

1f08350

Add Rust compiler

44fbe4b

Include {{ stdlib("c") }}

4d2a3d3

apcamargo added 3 commits February 12, 2025 12:16

Add python_min

430532c

Update meta.yaml

7fc5197

Remove noarch

038dc8e

Remove Python version requirements

437cbbb

apcamargo added 2 commits February 12, 2025 15:36

Add python as a build requirement and enable cross-compilation

fd4675d

Set Python >= 3.10

0ada01a

Add noarch

b34d26a

github-actions bot added python review-requested labels Feb 13, 2025

apcamargo added 2 commits February 13, 2025 11:15

Add cargo-bundle-licenses

e4a3a5c

Change directory before running cargo-bundle-licenses

736f48b

apcamargo added 3 commits February 13, 2025 16:43

Include the C compiler in the build requirements

5cd8c34

Fix typo

a734ae7

Add libgcc as a runtime dependency for Linux

c6035d9

Add stdlib

f88cedb

ocefpaf reviewed Feb 14, 2025

View reviewed changes

recipes/intervalues/meta.yaml Outdated Show resolved Hide resolved

recipes/intervalues/meta.yaml Outdated Show resolved Hide resolved

recipes/intervalues/meta.yaml Outdated Show resolved Hide resolved

recipes/intervalues/meta.yaml Show resolved Hide resolved

e2fa04c

Fix name

553173b

ocefpaf merged commit ce15ee0 into conda-forge:main Feb 14, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `intervalues` #29110

Add `intervalues` #29110

apcamargo commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025

conda-forge-admin commented Feb 12, 2025

conda-forge-admin commented Feb 12, 2025

conda-forge-admin commented Feb 12, 2025 •

edited

Loading

conda-forge-admin commented Feb 12, 2025

conda-forge-admin commented Feb 12, 2025

conda-forge-admin commented Feb 13, 2025

conda-forge-admin commented Feb 13, 2025 •

edited

Loading

apcamargo commented Feb 13, 2025

ocefpaf commented Feb 13, 2025

apcamargo commented Feb 13, 2025 •

edited

Loading

conda-forge-admin commented Feb 14, 2025 •

edited

Loading

apcamargo commented Feb 14, 2025

conda-forge-admin commented Feb 14, 2025

apcamargo commented Feb 14, 2025

Add intervalues #29110

Add intervalues #29110

Conversation

apcamargo commented Feb 12, 2025 • edited Loading

github-actions bot commented Feb 12, 2025

conda-forge-admin commented Feb 12, 2025

conda-forge-admin commented Feb 12, 2025

conda-forge-admin commented Feb 12, 2025 • edited Loading

conda-forge-admin commented Feb 12, 2025

conda-forge-admin commented Feb 12, 2025

conda-forge-admin commented Feb 13, 2025

conda-forge-admin commented Feb 13, 2025 • edited Loading

apcamargo commented Feb 13, 2025

ocefpaf commented Feb 13, 2025

apcamargo commented Feb 13, 2025 • edited Loading

conda-forge-admin commented Feb 14, 2025 • edited Loading

apcamargo commented Feb 14, 2025

conda-forge-admin commented Feb 14, 2025

apcamargo commented Feb 14, 2025

Add `intervalues` #29110

Add `intervalues` #29110

apcamargo commented Feb 12, 2025 •

edited

Loading

conda-forge-admin commented Feb 12, 2025 •

edited

Loading

conda-forge-admin commented Feb 13, 2025 •

edited

Loading

apcamargo commented Feb 13, 2025 •

edited

Loading

conda-forge-admin commented Feb 14, 2025 •

edited

Loading