Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pin to cmake <3.29.1. #270

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

teo-tsirpanis
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering) (no changes made)
  • Ensured the license file is being packaged.

Fixes TileDB-Inc/conda-forge-nightly-controller#83.

We pass an (undocumented) option when configuring TileDB that has the effect of disabling making an outer "superbuild" build tree, which is no longer needed now that we are using vcpkg. Without the superbuild, configuring TileDB no longer fails on CMake 3.29.1 (for reasons I don't know), allowing us to remove the pin to version <3.29.1.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jdblischak
Copy link
Member

I have to admit I'm confused about TILEDB_CMAKE_IDE. Given that we no longer allow the External Project setup, we should update the documentation around this CMake option so it is more transparent what it is doing.

(Used for CLion builds). Disables superbuild and sets the EP install dir.

Could you please push these changes directly to the nightly-build branch of the TileDB-Inc fork? As long as that passes, then I'm fine with merging this PR.

@teo-tsirpanis
Copy link
Member Author

The nightly build fails. 😩

@jdblischak
Copy link
Member

@teo-tsirpanis thanks for checking. Let's not merge until the Webp error is resolved

@teo-tsirpanis
Copy link
Member Author

CMake 3.29.2 reverted the change that caused the failures. I launched a nightly build with the pin removed. I also reverted disabling the superbuild.

@jdblischak
Copy link
Member

Note that the win-64 failure of the nightly build is unrelated to the CMake issue. It's related to vs2022 and the new key c_stdlib_version (TileDB-Inc/conda-forge-nightly-controller#86 (comment))

I also want to test c_stdlib_version, so I'm going to push to "nightly-build" as well

Co-authored-by: Isaiah Norton <ihnorton@users.noreply.github.com>
@jdblischak jdblischak requested a review from ihnorton April 12, 2024 19:05
@ihnorton ihnorton merged commit 49066ca into conda-forge:main Apr 15, 2024
8 checks passed
@teo-tsirpanis teo-tsirpanis deleted the cmake-fix branch April 15, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nighly feedstock build failed
4 participants