-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pin to cmake <3.29.1. #270
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I have to admit I'm confused about
Could you please push these changes directly to the nightly-build branch of the TileDB-Inc fork? As long as that passes, then I'm fine with merging this PR. |
@teo-tsirpanis thanks for checking. Let's not merge until the Webp error is resolved |
feb5aa7
to
e3cec1b
Compare
CMake 3.29.2 reverted the change that caused the failures. I launched a nightly build with the pin removed. I also reverted disabling the superbuild. |
Note that the win-64 failure of the nightly build is unrelated to the CMake issue. It's related to vs2022 and the new key I also want to test |
Co-authored-by: Isaiah Norton <ihnorton@users.noreply.github.com>
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering) (no changes made)Fixes TileDB-Inc/conda-forge-nightly-controller#83.
We pass an (undocumented) option when configuring TileDB that has the effect of disabling making an outer "superbuild" build tree, which is no longer needed now that we are using vcpkg. Without the superbuild, configuring TileDB no longer fails on CMake 3.29.1 (for reasons I don't know), allowing us to remove the pin to version
<3.29.1
.