Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conda-store server launch uvicorn with log level #940

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Oct 31, 2024

Fixes # #516
(along with #903)

Description

This change ensures that the log level set by the CondaStoreServer.log_level config gets applied to the uvicorn server. The default behaviour remains the same, that is, the log level is set to INFO by default (this is the default by uvicorn when the log_level is not set).

To test this out, try running a conda-store server with the following configs:

See info level logging (currently, the only option)

c.CondaStoreServer.log_level = logging.INFO

See critical level logging (pretty much no logs output)

c.CondaStoreServer.log_level = logging.CRITICAL

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@soapy1 soapy1 requested a review from peytondmurray October 31, 2024 01:08
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 5153e14
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6722d889188cd40008a2526c

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit e85460f
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6722d891c0a07800080d6242

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peytondmurray peytondmurray merged commit 8a9a54c into conda-incubator:main Oct 31, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants