Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing activate_in_script in allowed FIELDS #4771

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

npanpaliya
Copy link

Description

activate_in_script is missing from FIELDS because of which conda_build.api.check was failing for recipes having activate_in_script in the build section.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @npanpaliya.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

@npanpaliya
Copy link
Author

I've signed the CLA.

@npanpaliya
Copy link
Author

I've followed the steps of signing CLA twice, still the PR check shows as failed.

Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

1 similar comment
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added stale [bot] marked as stale due to inactivity labels Feb 16, 2024
@npanpaliya npanpaliya requested a review from a team as a code owner February 26, 2024 15:51
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 26, 2024
kenodegard
kenodegard previously approved these changes Feb 26, 2024
@kenodegard kenodegard enabled auto-merge (squash) February 26, 2024 15:54
@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Feb 27, 2024
Copy link

codspeed-hq bot commented Mar 25, 2024

CodSpeed Performance Report

Merging #4771 will not alter performance

Comparing npanpaliya:add-activate-in-script (54b214a) with main (51f81ce)

Summary

✅ 3 untouched benchmarks

@kenodegard
Copy link
Contributor

The tests are failing because setting the field type to bool changes the default value for build/activate_in_script to False. Without setting the field type the default value is None which translates to True in MetaData.activate_in_script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA stale::recovered [bot] recovered after being marked as stale
Projects
Status: 🏗️ In Progress
Development

Successfully merging this pull request may close these issues.

3 participants