-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only fetch lfs
files for specific git_ref
#5202
Conversation
We require contributors to sign our Contributor License Agreement and we don't have one on file for @Tobias-Fischer. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#881), and ping the bot to refresh the PR. |
@conda-bot check |
Hi @kenodegard - any chance to run this again, please? |
I think this is ready to go - all CI failures are unrelated :) |
A quick reminder @kenodegard :) |
@Tobias-Fischer thanks for checking in, we're still working to resolve the unrelated test failures caused by upstream deprecations, once we untangle that we'll get this moving again |
CodSpeed Performance ReportMerging #5202 will not alter performanceComparing Summary
|
lfs
files for specific git_ref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate you providing the additional context in the PR notes. This looks pretty straight forward and a good win all-around. Thanks!
Description
Currently conda-build fetches all lfs files that ever existed in the history. This is not necessary, and as outlined in #4809 is costly when e.g. using GitHub. For the specific use case that I have in mind (see RoboStack/ros-humble#155), the lfs files were actually removed from the repository and moved elsewhere (as the GitHub limits were exceeded, and now require payment), but the conda build still fails.
We already have the
git_ref
that we are interested in, so this is a relatively minor change; much smaller than making git-lfs completely optional as suggested in #4809Checklist - did you ...
news
directory (using the template) for the next release's release notes?