Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match build strings with globs #5600

Merged
merged 14 commits into from
Feb 19, 2025
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jan 25, 2025

Description

See #5571 (comment)

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 25, 2025
Copy link

codspeed-hq bot commented Jan 25, 2025

CodSpeed Performance Report

Merging #5600 will not alter performance

Comparing jaimergp:match-build-strings-glob (e576ee6) with main (5413773)

Summary

✅ 5 untouched benchmarks

@beckermr
Copy link
Contributor

@jaimergp can we use the latest blas/blis failure from @h-vetinari to add a test here?

@jaimergp
Copy link
Contributor Author

Added.

@jaimergp
Copy link
Contributor Author

jaimergp commented Feb 4, 2025

Windows CI errors are unrelated and caused by mamba-org/mamba#3730.

@beckermr
Copy link
Contributor

beckermr commented Feb 4, 2025

I'm happy to merge this as is, but am waiting on you @jaimergp. Any blockers or should we go ahead?

@jaimergp
Copy link
Contributor Author

Any blockers or should we go ahead?

Those macos failures are odd :/

@beckermr
Copy link
Contributor

pre-commit.ci autofix

1 similar comment
@beckermr
Copy link
Contributor

pre-commit.ci autofix

@beckermr
Copy link
Contributor

@jaimergp looks like the retries I added fixed this for now...

@jaimergp jaimergp marked this pull request as ready for review February 18, 2025 20:21
@jaimergp jaimergp requested a review from a team as a code owner February 18, 2025 20:21
@jaimergp
Copy link
Contributor Author

Awesome! Thank you so much. This is then ready.

@beckermr beckermr merged commit 9eead20 into conda:main Feb 19, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

3 participants