fix: refactor the shortcut filename

conda · Mar 4, 2025 · 27d8b6c · 27d8b6c
1 parent 655448e
commit 27d8b6c
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/crates/rattler_menuinst/src/windows.rs b/crates/rattler_menuinst/src/windows.rs
@@ -38,11 +38,6 @@ pub struct Directories {
     windows_terminal_settings_files: Vec<PathBuf>,
 }
 
-fn shortcut_filename(name: &str, ext: Option<&str>) -> String {
-    let ext = ext.unwrap_or("lnk");
-    format!("{name}{env}.{ext}")
-}
-
 /// On Windows we can create shortcuts in several places:
 /// - Start Menu
 /// - Desktop
@@ -132,7 +127,7 @@ impl WindowsMenu {
     ) -> Self {
         let name = command.name.resolve(Environment::Base, placeholders);
 
-        let shortcut_name = shortcut_filename(&name, Some(SHORTCUT_EXTENSION));
+        let shortcut_name = format!("{name}.{SHORTCUT_EXTENSION}");
 
         let location = directories
             .start_menu
@@ -195,9 +190,7 @@ impl WindowsMenu {
     }
 
     fn path_for_script(&self) -> PathBuf {
-        self.prefix
-            .join("Menu")
-            .join(shortcut_filename(&self.name, Some("bat")))
+        self.prefix.join("Menu").join(format!("{}.bat", &self.name))
     }
 
     fn build_command(&self, with_arg1: bool) -> Result<Vec<String>, MenuInstError> {