add Version.compare

js-rattler/crate/version.rs

@@ -1,6 +1,6 @@
 use crate::JsResult;
 use rattler_conda_types::{Version, VersionBumpType};
-use std::{cmp::Ordering, str::FromStr};
+use std::str::FromStr;
 use wasm_bindgen::prelude::wasm_bindgen;
 
 #[wasm_bindgen]
@@ -130,12 +130,4 @@ impl JsVersion {
     pub fn equals(&self, other: &Self) -> bool {
         self.as_ref() == other.as_ref()
     }
-
-    pub fn compare(&self, other: &Self) -> i8 {
-        match self.as_ref().cmp(other.as_ref()) {
-            Ordering::Less => -1,
-            Ordering::Equal => 0,
-            Ordering::Greater => 1,
-        }
-    }
 }

js-rattler/src/Version.test.ts

@@ -251,12 +251,4 @@ describe("Version", () => {
             expect(new Version("1.2.3a").withAlpha().toString()).toBe("1.2.3a");
         });
     });
-
-    describe("compare", () => {
-        it("should compare version with expected order", () => {
-            expect(new Version("1.2.3").compare(new Version("1.2.3"))).toBe(0);
-            expect(new Version("1.2.0").compare(new Version("1.2.3"))).toBe(-1);
-            expect(new Version("1.2.4").compare(new Version("1.2.3"))).toBe(1);
-        });
-    });
 });

js-rattler/src/Version.ts

@@ -195,13 +195,4 @@ export class Version {
     public withAlpha(): Version {
         return Version.fromNative(this.native.with_alpha());
     }
-
-    /**
-     * Compare 2 versions.
-     *
-     * Returns `-1` if self<other, `0` if self == other, `1` if self > other
-     */
-    public compare(other: Version): number {
-        return this.native.compare(other.native);
-    }
 }