refactor: create reader from opendal buffer (#1123)

conda · Feb 28, 2025 · 6e13ecb · 6e13ecb
1 parent 9466e38
commit 6e13ecb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/rattler_index/Cargo.toml b/crates/rattler_index/Cargo.toml
@@ -32,6 +32,7 @@ path = "src/main.rs"
 
 [dependencies]
 anyhow = { workspace = true }
+bytes = { workspace = true }
 clap = { workspace = true, features = ["derive", "env"] }
 clap-verbosity-flag = { workspace = true, features = ["tracing"] }
 console = { workspace = true }

diff --git a/crates/rattler_index/src/lib.rs b/crates/rattler_index/src/lib.rs
@@ -3,6 +3,7 @@
 #![deny(missing_docs)]
 
 use anyhow::Result;
+use bytes::buf::Buf;
 use fs_err::{self as fs};
 use futures::future::try_join_all;
 use fxhash::FxHashMap;
@@ -249,13 +250,12 @@ async fn index_subdir(
                         ));
                         let file_path = format!("{subdir}/{filename}");
                         let buffer = op.read(&file_path).await?;
-                        let bytes = buffer.to_vec();
-                        let cursor = Cursor::new(bytes);
+                        let reader = buffer.reader();
                         // We already know it's not None
                         let archive_type = ArchiveType::try_from(&filename).unwrap();
                         let record = match archive_type {
-                            ArchiveType::TarBz2 => package_record_from_tar_bz2_reader(cursor),
-                            ArchiveType::Conda => package_record_from_conda_reader(cursor),
+                            ArchiveType::TarBz2 => package_record_from_tar_bz2_reader(reader),
+                            ArchiveType::Conda => package_record_from_conda_reader(reader),
                         }?;
                         pb.inc(1);
                         Ok::<(String, PackageRecord), std::io::Error>((filename.clone(), record))