-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use opendal
in rattler-index
and add executable
#1076
Merged
Merged
Changes from 26 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
d0085a3
Init opendal
delsner 8c58912
Merge branch 'main' of github.com:pavelzw/rattler into rattler-index-…
delsner f326733
wip: Add index function
delsner 76afe88
wip
pavelzw 87b4d84
wip
delsner a347827
Initial version
delsner dd01d4f
don't fail on not found repodata
pavelzw ac8ea01
add progress bars
pavelzw 554f00b
Finalize implementation
delsner 8a99102
Fixes
delsner ab1b0a3
Fixes
delsner 59a0bdc
Prune cargo toml
delsner 563c66e
Fix comment
delsner 6b8a13a
Remove tracing log
delsner 52fae88
Merge branch 'main' into rattler-index-opendal
delsner 1344176
Update tests and pyrattler
delsner 131138a
fix lint
pavelzw 7341218
Fix docstrings
delsner efe483c
Add s3 integration test to pyrattler
delsner 39713a8
Remove assert_cmd
delsner b1a5bb2
Add finish print
delsner 63a09e0
Apply suggestions from code review
delsner b1425d2
Review
delsner 6e7add6
Update crates/rattler_index/src/lib.rs
delsner e38dc2d
Merge branch 'main' into rattler-index-opendal
delsner 7b7261a
add rustls-tls native certs
pavelzw c7785b8
rustls and native-tls
pavelzw bf8445d
Merge remote-tracking branch 'upstream/main' into rattler-index-opendal
pavelzw d010241
fix
pavelzw a869c2d
fix
pavelzw c592135
Merge branch 'main' into rattler-index-opendal
wolfv 57d52c3
clippy
delsner 867a49d
Fix clippy
delsner e2829f0
bump rust in py-rattler as well?
pavelzw cdb5daa
Merge remote-tracking branch 'upstream/main' into rattler-index-opendal
pavelzw 0133a55
add gitattributes
pavelzw ded2ee7
lockfile
pavelzw 8fc824c
add keys
pavelzw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,22 +3,49 @@ name = "rattler_index" | |
version = "0.20.12" | ||
edition.workspace = true | ||
authors = [] | ||
description = "A crate that indexes directories containing conda packages to create local conda channels" | ||
description = "A crate to index conda channels and create a repodata.json file." | ||
categories.workspace = true | ||
homepage.workspace = true | ||
repository.workspace = true | ||
license.workspace = true | ||
readme.workspace = true | ||
default-run = "rattler-index" | ||
|
||
[[bin]] | ||
name = "rattler-index" | ||
path = "src/main.rs" | ||
Comment on lines
+31
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i would suggest we don't publish binaries for rattler-index in this repo as this will probably complicate the release-plz workflow in this repo quite a bit. instead, we can only build binaries on conda-forge (and other package managers like brew), imo this should be enough |
||
|
||
[dependencies] | ||
anyhow = { workspace = true } | ||
clap = { workspace = true, features = ["derive", "env"] } | ||
clap-verbosity-flag = { workspace = true } | ||
console = { workspace = true } | ||
fs-err = { workspace = true } | ||
rattler_conda_types = { path="../rattler_conda_types", version = "0.30.3", default-features = false } | ||
rattler_digest = { path="../rattler_digest", version = "1.0.6", default-features = false } | ||
rattler_package_streaming = { path="../rattler_package_streaming", version = "0.22.28", default-features = false } | ||
fxhash = { workspace = true } | ||
futures = { workspace = true } | ||
indicatif = { workspace = true } | ||
opendal = { workspace = true, features = [ | ||
"services-s3", | ||
"services-fs", | ||
], default-features = false } | ||
rattler_networking = { path = "../rattler_networking", version = "0.22.4", features = [ | ||
"rustls-tls", | ||
], default-features = false } | ||
rattler_conda_types = { path = "../rattler_conda_types", version = "0.30.3", default-features = false } | ||
rattler_digest = { path = "../rattler_digest", version = "1.0.6", default-features = false } | ||
rattler_package_streaming = { path = "../rattler_package_streaming", version = "0.22.28", features = [ | ||
"rustls-tls", | ||
], default-features = false } | ||
reqwest = { workspace = true, features = [ | ||
"rustls-tls", | ||
"rustls-tls-native-roots", | ||
] } | ||
serde_json = { workspace = true } | ||
tempfile = { workspace = true } | ||
tokio = { workspace = true, features = ["full"] } | ||
tracing = { workspace = true } | ||
walkdir = { workspace = true } | ||
tracing-subscriber = { workspace = true, features = ["env-filter", "fmt"] } | ||
tracing-log = { workspace = true } | ||
url = { workspace = true } | ||
|
||
[dev-dependencies] | ||
tempfile = { workspace = true } | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still need to do the whole native-tls / rustls-tls and native-roots dance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in
c7785b8
(#1076)