feat: add Version.compare to wasm Version #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @trim21 awesome! I just merged (and squashed) the other PR - do you think you can rebase on main? Thank you for helping us! |
baszalmstra
reviewed
Feb 20, 2025
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
|
@trim21 you marked @baszalmstra comments as resolved but didn't do the changes yet. I am happy to merge once you did apply the suggestions. |
Oh, sorry, my mistake. I want to trigger the required ci jobs so did a force push, but with a old commit |
wolfv
reviewed
Feb 20, 2025
trim21
commented
Feb 20, 2025
|
done |
wolfv
approved these changes
Feb 20, 2025
|
Congrats on your first contribution! 🎉 |
travishathaway
pushed a commit
to travishathaway/rattler
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description