fix(js): use api-extractor to fix typings #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
reviewed
Feb 20, 2025
baszalmstra
changed the title
|
@trim21 Would love another review from you 😄 |
wolfv
reviewed
Feb 20, 2025
| @@ -83,7 +89,7 @@ export class Version { | |||
| * Returns true if this version starts with the other version. This is | |||
| * defined as the other version being a prefix of this version. | |||
| * | |||
| * @param other The version to check if this version starts with. | |||
| * @param other - He version to check if this version starts with. | |||
|
LGTM |
2 tasks
travishathaway
pushed a commit
to travishathaway/rattler
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://api-extractor.com/ to also rollup the typing definition file.