Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Version parsing bug #1122

Closed
wants to merge 1 commit into from
Closed

fix: Version parsing bug #1122

wants to merge 1 commit into from

Conversation

pavelzw
Copy link
Contributor

@pavelzw pavelzw commented Feb 28, 2025

@pavelzw pavelzw mentioned this pull request Feb 28, 2025
Open
@baszalmstra
Copy link
Collaborator

baszalmstra commented Feb 28, 2025 •
edited
Loading

We dont retain starting 0s. E.g. 01 is the same as 1.

But the VersionWithSource type does, and should be used if the input string matters!

@pavelzw
Copy link
Contributor Author

pavelzw commented Feb 28, 2025

with VersionWithSource it works 👍🏻

>>> str(rattler.VersionWithSource("0.1.0.dev12+ga47bad07"))
'0.1.0.dev12+ga47bad07'

then this is rattler-build's fault 👍🏻

@pavelzw pavelzw closed this Feb 28, 2025
@pavelzw pavelzw deleted the version-bug branch February 28, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelzw @baszalmstra