fix: roundtrip of arch/platform in lock files #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
commented
Feb 28, 2025
| }?; | ||
| // Convert back to Platform string which should correspond to known subdirs | ||
| Ok(plat.to_string()) | ||
| match arch.parse::<Arch>() { |
There was a problem hiding this comment.
the previous function was not covering e.g. emscripten-wasm32 so I modernized it a bit.
This was referenced Feb 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were filling in the
archandplatformfields in the lockfile if they didn't come from the repodata, but we didn't serialize this information on the first go.When loading the data from lockfile and re-serializing, we did write it out leading to roundtrip issues as noted in #1073
In this PR we just remove the writing of
archandplatform.