fix: shortcut filename #1136
Merged
fix: shortcut filename #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise Windows will not know what to do with it
|
Looks good! we should also double check if we should keep the |
|
This works on my windows machine compiled into pixi |
|
This was indeed changed in upstream menuinst: https://github.com/conda/menuinst/blob/fa02b329a15346728664edc7372bd43691ca915f/menuinst/platforms/win.py#L242-L244 Let's remove the |
ruben-arts
approved these changes
Mar 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, Windows will not know what to do with it