refactor(js): remove double wrap #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
force-pushed
the
js/refactor/remove_double_wrap
branch
from
0e9f70f to
a86ecaa
Compare
|
nice! |
wolfv
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the double wrapping of
VersionandVersionSpecand moves all the logic to Rust. This avoids creating an additional indirection in javascript which is easier to maintain and should be faster.Initially I double wrapped the types meaning we expose type A from rust, then create type B in typescript that wraps A and only expose B to the user. The advantage of this approach is that we can provide a more ergonomic API to the user. But I found wasm-bindgen flexible enough that we can provide the same level of ergonomics directly from Rust. wasm-bindgen allows overriding types which allows manual control in places where the generated API is a bit ugly.