fix: keep in mind python: noarch packages in clobber calculations #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
wolfv
force-pushed
the
fix-clobber-noarch
branch
from
c08a18d to
96a779b
Compare
baszalmstra
reviewed
Feb 12, 2024
wolfv
force-pushed
the
fix-clobber-noarch
branch
from
e9fd459 to
4cb8ae6
Compare
baszalmstra
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a bug where the
unclobberfunction tried to runfs::renameon non-existing files (because these files came fromnoarch: pythonpackages where the final path got renamed fromsite-packages/bla.pytolib/pythonX.X/site-packages/bla.py).This fix is relatively ugly (because we compute the "final" name for the file multiple times and entry points are also not properly handled yet.
Maybe we should discuss real quick how we want to handle entry points (entry points don't need to strictly be linked into the env since we can recreate them when we need to).