refactor(ci): move to smaller github action units

.github/workflows/build.yaml

@@ -84,6 +84,7 @@ jobs:
 
       - name: Build all (including tests, benches, examples)
         run: |
+          # TODO make building the bundle.car a dependency
           cd fendermint && make $PWD/builtin-actors/output/bundle.car
           cargo build --locked --release --all-targets
 

.github/workflows/ci.yaml

@@ -23,15 +23,6 @@ on:
 
 
 jobs:
-  commonmark:
-    uses: ./.github/workflows/commonmark-lint.yaml
-
-  license:
-    uses: ./.github/workflows/license.yaml
-
-  contracts-prettier:
-    uses: ./.github/workflows/contracts-prettier.yaml
-
   contracts-deployment-test:
     uses: ./.github/workflows/contracts-deployment-test.yaml
     needs: [contracts-prettier]

.github/workflows/contracts-test.yaml

@@ -21,7 +21,7 @@ jobs:
           cache: false
 
       - name: Cache Solidity ABI artifacts
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ./contracts/out

.github/workflows/demos.yaml

@@ -7,7 +7,7 @@ env:
   FOUNDRY_PROFILE: ci
 
 jobs:
-  examples-axelar-token:
+  demo-axelar-token:
     name: "Demos: Axelar token"
     runs-on: ubuntu-latest
     strategy:

.github/workflows/lint-code-quality.yaml

@@ -0,0 +1,69 @@
+name: Code Quality
+
+on:
+  push:
+    branches:
+      - main
+    # Pattern matched against refs/tags
+    tags:
+      # Push events to every git tag not containing /
+      # NOTE: '**' would match tags with / in them, e.g. "foo/bar",
+      # but we want to use the tag as a docker tag as well, so it's best avoided.
+      - '*'
+
+  pull_request:
+    branches:
+      - '**'
+    # To add ready_for_review as a trigger we need to list all the defaults.
+    types:
+      - opened
+      - reopened
+      - synchronize
+      - ready_for_review
+
+jobs:
+  rust:
+    name: Check Rust Code Quality
+    runs-on: ubuntu-22.04
+    env:
+      RUST_BACKTRACE: full
+      RUSTFLAGS: -Dwarnings
+
+    steps:
+    - name: Check out the project
+      uses: actions/checkout@v4
+      with:
+        submodules: recursive
+
+    - name: Install Tools
+      uses: ./.github/actions/install-tools
+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+        rust: 1.81.0
+
+    - name: Install Extra Libs
+      run: sudo apt-get install -y build-essential clang cmake pkg-config libssl-dev protobuf-compiler git curl
+
+    - name: Install Rust nightly
+      uses: dtolnay/rust-toolchain@master
+      with:
+        toolchain: nightly-2024-07-05
+        components: rustfmt,clippy
+
+    - name: Print Rust toolchain default versions
+      run: |
+        echo "rustup show:"
+        rustup show
+        echo "rustc version:"
+        rustc --version
+        echo "cargo version:"
+        cargo -V
+        echo "glibc version"
+        ldd --version
+
+    - name: Check fmt (nightly)
+      run: cargo +nightly-2024-07-05 fmt --check --all
+
+    - name: Check clippy
+      run: |
+        cargo clippy --release --tests --no-deps -- -D clippy::all

.github/workflows/commonmark-lint.yaml → .github/workflows/lint-commonmark.yaml

@@ -14,6 +14,6 @@ jobs:
     - name: Lint all commonmark/markdown files
       uses: DavidAnson/markdownlint-cli2-action@v19
       with:
-        fix: true
-        globs: '(scripts|crates)/**/README.md;contracts/specs/**/*.md;specs/**/*.md;docs/**/*.md'
+        fix: false
+        globs: '**/README.md;contracts/specs/**/*.md;specs/**/*.md;docs/**/*.md'
         separator: ';'

.github/workflows/license.yaml → .github/workflows/lint-license.yaml

@@ -10,11 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out the project
-        uses: actions/checkout@v3
-
-      # This is so `make license` doesn't say "bad revision origin/main"
-      - name: Fetch origin for diff
-        run: git fetch origin
+        uses: actions/checkout@v4
 
       - name: Check license headers
         run: make license

.github/workflows/lints.yaml

@@ -0,0 +1,30 @@
+name: "Lint PR title"
+
+on:
+  pull_request:
+    types:
+      - opened
+      - edited
+      - synchronize
+      - reopened
+
+permissions:
+  pull-requests: read
+
+jobs:
+  license:
+    uses: ./.github/workflows/lint-license.yaml
+
+  contracts-prettier:
+    uses: ./.github/workflows/lint-contracts-prettier.yaml
+
+  conventional-commits:
+    uses: ./.github/workflows/lint-convention-commits.yaml
+
+  commonmark:
+    uses: ./.github/workflows/lint-commonmark.yaml
+
+  code-quality:
+    uses: ./.github/workflows/lint-code-quality.yaml
+
+