Remove "optional" for GetVolumeGroupSnapshot to avoid confusion #580
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @bswartz |
|
I seem to remember similar language in the spec for other RPCs. Whatever we
decide to do here, we should be consistent everywhere.
…On Sun, Mar 2, 2025, 11:46 AM Xing Yang ***@***.***> wrote:
/assign @bswartz <https://github.com/bswartz>
—
Reply to this email directly, view it on GitHub
<#580 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5KLHODQ4HUXBII7EVOG32SMYV7AVCNFSM6AAAAABYFNV5SOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSHAYTCMJSGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
[image: xing-yang]*xing-yang* left a comment
(container-storage-interface/spec#580)
<#580 (comment)>
/assign @bswartz <https://github.com/bswartz>
—
Reply to this email directly, view it on GitHub
<#580 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5KLHODQ4HUXBII7EVOG32SMYV7AVCNFSM6AAAAABYFNV5SOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSHAYTCMJSGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I found similar language for ControllerGetVolume RPC. The only difference is that GET_VOLUME capability is only for ControllerGetVolume RPC, while CREATE_DELETE_GET_VOLUME_GROUP_SNAPSHOT capability is for Create/Delete/GetVolumeGroupSnapshot RPCs. Should we remove "optional" for ControllerGetVolume as well? |
Yes, we should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
cleanup
What this PR does / why we need it:
This PR removes "optional" from the following description about
GetVolumeGroupSnapshot. Technically this sentence is correct asGetVolumeGroupSnapshotis optional. However, it adds confusion as the sentence immediately following this says it must be implemented if a plugin hasCREATE_DELETE_GET_VOLUME_GROUP_SNAPSHOTcapability. For volume group snapshots, there is a single capability for create/delete/get volume group snapshots. If that capability is supported, all there RPCs create/delete/get must be implemented.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce an API-breaking change?: