Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): use published images instead of locally built ones #820

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Jan 28, 2025

  • Replaced make load with sudo make pull
  • Updated documents to pull images from ghcr.io instead of building them locally

- Replaced `make load` with `sudo make pull`
- Updated documents to pull images from `ghcr.io` instead of building them locally

Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
@Mossaka Mossaka force-pushed the use-published-images branch from 78796fa to 8341062 Compare January 29, 2025 06:12
…tions

for code reuse

Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
@Mossaka Mossaka closed this Jan 29, 2025
@Mossaka Mossaka reopened this Jan 29, 2025
jprendes
jprendes previously approved these changes Jan 29, 2025
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
This is great @Mossaka , thanks!

Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprendes jprendes merged commit ecc6799 into containerd:main Jan 29, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants