feat(otel): modify the span naming logic #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Mossaka
commented
Jan 29, 2025
Mossaka
commented
- Modify the span name from funcion name to the module path + function name
Mossaka
force-pushed
the
span-naming
branch
2 times, most recently
from
e1d740c to
ca8e9f8
Compare
jprendes
reviewed
Jan 29, 2025
jprendes
previously approved these changes
Jan 29, 2025
- Modify the span name from funcion name to the module path + function name Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
jprendes
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.