Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Rename the image wasi-http to wasi-demo-http #840

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Feb 6, 2025

Closes #825

Signed-off-by: Jiaxiao (mossaka) Zhou duibao55328@gmail.com

Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
@Mossaka
Copy link
Member Author

Mossaka commented Feb 7, 2025

The benchmark failed because they were trying to pull wasi-demo-http which doesn't exist yet. I think we can safely ignore this failure and as soon as this PR merged to main, I will release the new wasi-demo-http image.

Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can we publish the image with the new name?

@Mossaka Mossaka merged commit ab57831 into main Feb 13, 2025
71 of 74 checks passed
@Mossaka Mossaka deleted the issue825 branch February 13, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish runwasi/wasi-http as runwasi/wasi-demo-http
2 participants