Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tests of runtime options #884

Merged
merged 1 commit into from
Feb 27, 2025
Merged

feat: add tests of runtime options #884

merged 1 commit into from
Feb 27, 2025

Conversation

z63d
Copy link
Contributor

@z63d z63d commented Feb 27, 2025

Tests for #864

jprendes
jprendes requested changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @z63d.
Left a comment below.

@z63d
feat: add tests of runtime options
0637b2d 
Signed-off-by: Kaita Nakamura <kaita.nakamura0830@gmail.com>
@z63d z63d force-pushed the feat/test-runtime-options branch from 110d29f to 0637b2d Compare February 27, 2025 11:14
jprendes
jprendes approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @z63d !
LGTM

@Mossaka Mossaka merged commit dad1f31 into containerd:main Feb 27, 2025
77 checks passed
@z63d z63d deleted the feat/test-runtime-options branch February 27, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprendes jprendes jprendes approved these changes

@Mossaka Mossaka Mossaka approved these changes

Assignees
No one assigned
Labels
C-containerd-shim-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@z63d @jprendes @Mossaka