Use async for the instance's wait method #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
force-pushed
the
async-instance-wait
branch
from
65e5f95 to
23a22f8
Compare
jprendes
force-pushed
the
async-instance-wait
branch
3 times, most recently
from
47ff1a2 to
969ca6e
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
async-instance-wait
branch
from
969ca6e to
ae5cc22
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
async-instance-wait
branch
from
63aea5e to
8ae2435
Compare
cpuguy83
approved these changes
Feb 27, 2025
andreiltd
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
Instance's wait method to be async.This is a step towards migrating to an async shim.
This has the nice benefit that we get sync probing (
try_wait) and timed wait (wait_timeout) for free.We get probing through
FutureExt::now_or_never, and timed wait throughtokio::time::timeout.This also simplifies the implementation of
WaitableCella fair bit.