Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove unused engine field #887

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

jprendes
Copy link
Collaborator

There's an unused engine field in the Local struct that somehow was not being flagged as unused.
This PR removes that field, and related now redundant types.

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@jprendes jprendes force-pushed the remove-unused-engine branch from ecfcc2b to 8922827 Compare February 28, 2025 17:42
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Mossaka Mossaka merged commit 5da010f into containerd:main Mar 3, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants