Use volumes param for container rm #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
umohnani8
force-pushed
the
vol
branch
2 times, most recently
from
801490b to
03944fb
Compare
Use the volumes param instead of v to ensure that the libpod endpoint actually removes anonymous volumes when a container is deleted. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
umohnani8
changed the title
|
LGTM |
|
LGTM |
|
@rhatdan can you please merge |
|
/lgtm |
|
hell yeah! |
|
Could you please create a new release containing this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the volumes param instead of v to ensure that
the libpod endpoint actually removes anonymous volumes when a container is deleted.
Fixes #328