Fix the locally non-existent image fails with AttributeError #408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for running a new container with an image that is not present locally tries to access the
ImagesManager
viaself.client.images
.As
self.client
is anAPIClient
instance and not an instance ofPodmanClient
, anAttributeError
occurs:With this fix the
PodmanClient
object is used instead ofAPIClinet
correctly.A very minimal test code:
The above code failed with
AttributeError
before my fix. Currently it pulls the Image if it's not available in local and run the container.Note:
@cached_property
methods also can be extended with my solution if it's needed. I have extended only theContainersManager
withpodman_client
argument.It's fix for:
#378