Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance environment connection error handling #512

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Mr-Sunglasses
Copy link
Contributor

fix: #455

Add PodmanConnectionError to improve debugging of connection failures when
initializing client from environment variables. The new error provides:

  • Detailed error messages with connection host and environment state
  • Preservation of original exception information
  • Better context for common failure modes (invalid config, connection failures)

Previously, raw exceptions from connection attempts could be confusing to
diagnose, especially when involving environment variables. This change makes it
clearer what went wrong during client initialization.

Copy link
Contributor

openshift-ci bot commented Feb 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mr-Sunglasses
Once this PR has been reviewed and has the lgtm label, please assign umohnani8 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Mr-Sunglasses Mr-Sunglasses force-pushed the fix/connection-error branch 2 times, most recently from 2fe3b88 to a8c4fec Compare February 16, 2025 16:16
@Mr-Sunglasses
Copy link
Contributor Author

Hey @inknos , I've fixed all the suggested changes on PR: #472 in this PR because that was messed up and thanks @D3vil0p3r for your suggestion, I really helped me in resolving this issue.

@inknos
Copy link
Contributor

inknos commented Feb 17, 2025

Thanks, I'll look into it. Since the first time you committed, many things have changed in the codebase and we reformatted and dropped quite a lot of old code. I'll help you with this to fix the remaining issues. it should be a matter of passing the lint and few other things :)

@Mr-Sunglasses
Copy link
Contributor Author

Thanks, I'll look into it. Since the first time you committed, many things have changed in the codebase and we reformatted and dropped quite a lot of old code. I'll help you with this to fix the remaining issues. it should be a matter of passing the lint and few other things :)

Sure thanks @inknos , looking forward to your review and also happy to resolve more bugs 😄

@inknos inknos self-requested a review February 18, 2025 13:05
@inknos
Copy link
Contributor

inknos commented Feb 19, 2025

hey. @Mr-Sunglasses I was working on #510 to fix the tests flake that hit the packit jobs, and now they should be good (it was about the infinite running tests). I also published 5.4.0 within the same PR and that should fix all the red lights 🤞🏻 . you might want to pull main, rebase and push your commits again :)

@Mr-Sunglasses
Copy link
Contributor Author

Mr-Sunglasses commented Feb 19, 2025

hey. @Mr-Sunglasses I was working on #510 to fix the tests flake that hit the packit jobs, and now they should be good (it was about the infinite running tests). I also published 5.4.0 within the same PR and that should fix all the red lights 🤞🏻 . you might want to pull main, rebase and push your commits again :)

Sure @inknos thanks a lot, it'll do that right away :-)

Let's hope for the best that all tests pass 🧿🤞🏻

Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Signed-off-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET operation failed - when running podman as sudo
2 participants