Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject toml fixed for podman submodules invisibility #515

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

jyejare
Copy link
Contributor

@jyejare jyejare commented Feb 19, 2025

Fixes #514

@inknos
Copy link
Contributor

inknos commented Feb 19, 2025

@jyejare great catch and quick fix, thank you so much. please sign the commit and push it again, I'll approve it and release the fix

Signed-off-by: jyejare <jyejare@redhat.com>
@inknos inknos self-requested a review February 19, 2025 12:13
@jyejare
Copy link
Contributor Author

jyejare commented Feb 19, 2025

@inknos Done, Sorry I missed that at first.

@inknos
Copy link
Contributor

inknos commented Feb 19, 2025

That's ok. I am approving the checks and will follow up soon. Thanks again

@jyejare
Copy link
Contributor Author

jyejare commented Feb 19, 2025

@inknos Yeah, my pleasure. Saw that as a quick fix and dont want podman python world to shout because of that :)

@inknos
Copy link
Contributor

inknos commented Feb 19, 2025

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, jyejare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 49d8827 into containers:main Feb 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman sub-packages are not detected in 5.4.0
2 participants