Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump release to 5.4.1 #516

Closed
wants to merge 1 commit into from
Closed

Bump release to 5.4.1 #516

wants to merge 1 commit into from

Conversation

inknos
Copy link
Contributor

@inknos inknos commented Feb 19, 2025

No description provided.

Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inknos inknos changed the title Bump release to 5.4.0.1 Bump release to 5.4.1 Feb 19, 2025
Signed-off-by: Nicola Sella <nsella@redhat.com>
@inknos
Copy link
Contributor Author

inknos commented Feb 19, 2025

This would probably not work, I am opening #517 with the plan of tagging upstream with 5.4.0.1. Then pypi will have a 5.4.0.1 build too and I can yank 5.4.0 without disruption of the upgrade path.

I considered replacing the tag upstream, but pypi would not replace a file with the same name. Furthermore, this would lead to breakage of buildsystems which pulled podman-py already and it would also break any upgrade path.

The reason why 5.4.0 is not possible is because the podman-py and podman endpoints are in sync, so podman py 5.4.1 will fail to make REST calls if /libpod/v5.4.1 is not found

@inknos
Copy link
Contributor Author

inknos commented Feb 19, 2025

Closing in favor of 5.4.0.1 solution

@inknos inknos closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant