-
Notifications
You must be signed in to change notification settings - Fork 2.6k
libpod: fix a confusing error message from 'podman system reset' on F… #24150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dfr ping still working on this? |
Sorry - I was busy with other things and then away on a trip. I will refresh this and take a look into |
86b7a65
to
030408a
Compare
Rebased and made (*Runtime).Migrate a no-op stub which allows |
/approve |
LGTM |
030408a
to
a93a39a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…reeBSD This was discovered by a user while testing Podman on FreeBSD (oci-playground/freebsd-podman-testing/issues/17). The error message didn't stop 'podman system reset' from working and this commit simply suppressses the error on FreeBSD. Signed-off-by: Doug Rabson <dfr@rabson.org>
a93a39a
to
0463ad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Luap99 this one is approved, can you merge this? |
/cherry-pick v5.5 |
@Luap99: new pull request created: #25985 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…reeBSD
This was discovered by a user while testing Podman on FreeBSD (oci-playground/freebsd-podman-testing/issues/17). The error message didn't stop 'podman system reset' from working and this commit simply suppressses the error on FreeBSD.
Does this PR introduce a user-facing change?