Skip to content

libpod: fix a confusing error message from 'podman system reset' on F… #24150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

dfr
Copy link
Contributor

@dfr dfr commented Oct 3, 2024

…reeBSD

This was discovered by a user while testing Podman on FreeBSD (oci-playground/freebsd-podman-testing/issues/17). The error message didn't stop 'podman system reset' from working and this commit simply suppressses the error on FreeBSD.

Does this PR introduce a user-facing change?

None

@Luap99
Copy link
Member

Luap99 commented Oct 30, 2024

@dfr ping still working on this?

@dfr
Copy link
Contributor Author

dfr commented Oct 30, 2024

Sorry - I was busy with other things and then away on a trip. I will refresh this and take a look into podman system migrate.

@dfr dfr force-pushed the freebsd-system-reset branch from 86b7a65 to 030408a Compare December 1, 2024 10:29
@dfr
Copy link
Contributor Author

dfr commented Dec 1, 2024

Rebased and made (*Runtime).Migrate a no-op stub which allows podman system reset on FreeBSD.

@rhatdan rhatdan added the No New Tests Allow PR to proceed without adding regression tests label Dec 2, 2024
@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2024

/approve

@rhatdan
Copy link
Member

rhatdan commented Dec 2, 2024

LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@dfr dfr force-pushed the freebsd-system-reset branch from 030408a to a93a39a Compare December 3, 2024 14:01
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…reeBSD

This was discovered by a user while testing Podman on FreeBSD
(oci-playground/freebsd-podman-testing/issues/17). The error message
didn't stop 'podman system reset' from working and this commit simply
suppressses the error on FreeBSD.

Signed-off-by: Doug Rabson <dfr@rabson.org>
@dfr dfr force-pushed the freebsd-system-reset branch from a93a39a to 0463ad1 Compare February 11, 2025 15:13
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasperk81
Copy link

@Luap99 this one is approved, can you merge this?

@openshift-merge-bot openshift-merge-bot bot merged commit 5c5ecde into containers:main Apr 25, 2025
83 checks passed
@Luap99
Copy link
Member

Luap99 commented Apr 25, 2025

/cherry-pick v5.5

@openshift-cherrypick-robot
Copy link
Collaborator

@Luap99: new pull request created: #25985

In response to this:

/cherry-pick v5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants