Skip to content

[v5.5] Fix: inheritlabels=true if query param absent #26003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #25983

/assign Luap99

matejvasek and others added 2 commits April 28, 2025 17:38
The inheritlabels param must default to true if query param is absent.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Apr 28, 2025
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Apr 28, 2025
@Luap99 Luap99 added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Apr 28, 2025
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025
@TomSweeneyRedHat
Copy link
Member

LGTM
I've restarted the failing test. It looked like an initial pull failed, and the second attempt succeeded, but the test wasn't expecting the extra warning about the first failure.

@openshift-merge-bot openshift-merge-bot bot merged commit 3a594b4 into containers:v5.5 Apr 28, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants