Update "check.c" to be C23 compliant #26009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compilation errors with GCC 15. Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
|
Thank you @arixmkii. As you know we want to remove |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arixmkii, l0rd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation errors with GCC 15.
GCC 15 defaults to C23 standard, which introduced new keywords (including
bool): https://gcc.gnu.org/gcc-15/porting_to.html#c23Alternative fix would be to change build script to use lower C standard version.
It seems that at some point this file might be removed, because installer would not be responsible for installing dependencies anymore, but for now this fix would allow to build Podman installer with msys2 tooling (they upgraded
GCC to 15).
Does this PR introduce a user-facing change?