Makefile: move some Go-related variable definitions up #26015
Conversation
|
@markjdb Looks like the tests are failing due to an infrastructure problem. Can you please try to run the tests again? |
Otherwise we evaluate NATIVE_GOOS before it is set, which breaks the FreeBSD build since various make variables are not set correctly. Fixes: containers#26006 Signed-off-by: Mark Johnston <mark.johnston@klarasystems.com>
Now there are only a couple of failures, but it's not really clear to me whether they're possibly related to the change or not. |
openshift-ci
bot
added
the
approved
|
/cherry-pick v5.5 |
|
@Luap99: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, Luap99, markjdb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@Luap99: new pull request created: #26024 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Otherwise we evaluate NATIVE_GOOS before it is set, which breaks the FreeBSD build.
Fixes: #26006
Does this PR introduce a user-facing change?