Skip to content

Note vrf in network create is experimental #26028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Note vrf in network create is experimental #26028

wants to merge 1 commit into from
+1 −1

Conversation

TomSweeneyRedHat
Copy link
Member

The value vrf for the --opt option in the network create command is not supported and is experimental at this time. Document it as such.

Does this PR introduce a user-facing change?

None

@TomSweeneyRedHat
Note vrf in network create is experimental
c883022 
The value `vrf` for the `--opt` option in the network create command
is not supported and is experimental at this time.  Document it as such.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat added documentation Issue or fix is in project documentation No New Tests Allow PR to proceed without adding regression tests labels Apr 30, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2025
Luap99
Luap99 reviewed Apr 30, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly makes this not supported and experimental? Sure there are some bugs/problems but those should get fixed and not used as excuse to say we don't support it?

If this is for RHEL then the RHEL docs should say that not upstream?

@TomSweeneyRedHat
Copy link
Member Author

Yes, we're making it TP in RHEL via a separate Jira card.

The reason for this change was based on what I heard, I thought this was a hot mess right now. Until it's fixed, I think it's good to note it's problematic, YMMV.

I'm fine with merging this or closing it. Your call.

@Luap99
Copy link
Member

Luap99 commented May 2, 2025

IMO going back retrospectively and marking this as experimental doesn't make any sense, I see no specific reason why this would have any more bugs than any other upstream contribution we accept.

I am aware of two problems with vrf, the port forwarding not working (https://issues.redhat.com/browse/RHEL-88574) and dns not working (containers/aardvark-dns#562). Both of which just need time to work through, if users want to use it I see no reason to pull out an "actually we do not support it" card we should just spend the time to fix it. (That is assuming the kernel team supports vrf devices)

@Luap99 Luap99 closed this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. documentation Issue or fix is in project documentation No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomSweeneyRedHat @Luap99