add owner cleanup #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
force-pushed
the
add-owner-cleanup
branch
from
f32a992 to
3411e3a
Compare
In the case that a duration is set (the pod or pod template activeDeadlineSeconds) kick off a cleanup job to remove it from Kubernetes and the scheduler. Other deletions will need to be handled with events, which I will do next! I also changed my mind about the default deletion of 3600 - I think that can be dangerous for services or other stuffs that should not be expected to just end. We need to trust the users creating the abstractions. Also, pods that are associated with jobs clean themselves up, so we do not want to double mess with that. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
add-owner-cleanup
branch
from
3411e3a to
fa3d2e3
Compare
Currently, this variable is not exposed via the grpc. We want to expose it to customize it, but also be pedantic to say that we do not want fluxion to return an error if the jobid does not exist. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that a duration is set (the pod or pod template activeDeadlineSeconds) kick off a cleanup job to remove it from Kubernetes and the scheduler. Other deletions will need to be handled with events, which I will do next! I also changed my mind about the default deletion of 3600 - I think that can be dangerous for services or other stuffs that should not be expected to just end. We need to trust the users creating the abstractions.