Get 1.19 branch going #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S14: Malakar no longer comments on gargoyles if player completed S6B
Avoids wmllint error
also ignore map-diff stuff in `_server.ign`
1.18 upstream update
|
Looks like one of us might need to start our 1.19 branch over... |
MadMax3947
approved these changes
Jan 29, 2025
cooljeanius
commented
Jan 29, 2025
cooljeanius
commented
Jan 29, 2025
cooljeanius
commented
Jan 29, 2025
scenarios_b/08b_Apocalypse.cfg
Outdated
| # team_name=evil | ||
| # user_team_name= _ "Wesnoth Expeditionary Force" | ||
| # hidden=yes | ||
| #[/side] |
There was a problem hiding this comment.
Generally I prefer ifdef-ing unused code out, instead of commenting it out... or, just removing it would be fine, too...
cooljeanius
commented
Jan 29, 2025
cooljeanius
commented
Jan 29, 2025
units.cfg
Outdated
| # ignore_global_traits=yes | ||
| # {TRAIT_MECHANICAL} | ||
| # {HUMAN_NAMES} | ||
| #[/race] |
There was a problem hiding this comment.
Again, I'd prefer ifdef-ing this out, or removing it entirely, instead of commenting it out.
cooljeanius
commented
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just getting this started; it can come out of draft mode once it's ready...
Closes #11 upon merge.