5.7.1 #49
Merged
5.7.1 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ash fall weather Add more weather ambient sounds Use Durzi's AW&S weather implementation if available (otherwise fall back to our own)
…cene on higher difficulties
Would likely only list book 10 as an optional dependency since it's used a lot more than other UMC music
|
will take a look later; got some other stuff to do first... |
cooljeanius
reviewed
Feb 6, 2025
cooljeanius
reviewed
Feb 6, 2025
cooljeanius
reviewed
Feb 6, 2025
cooljeanius
reviewed
Feb 6, 2025
|
I'm still intending to add the comments I mentioned in the actual code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a few bug fixes. Also utilizes Durzi's Animated Weather and Scenery for weather effects if it's available; better performance than the
[terrain_graphics]implementation used by mainline Wesnoth along with increased variety of effects. However fall back to[terrain_graphics]implementation if AWaS not available.Additionally, if this is merged then in the .pbl I'll probably not list UMC Book 10 (not yet on the 1.19 add-on server) as a dependency to avoid discouraging campaign downloads.