chrysn's nits collected during review #109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabo
reviewed
Feb 20, 2025
| @@ -478,7 +478,7 @@ references: | |||
| base CRI). | |||
|
|
|||
| Application specifications that use CRIs may explicitly enable the use | |||
| of "stand-in" items (tags or simple values). | |||
| of "stand-in" items (tags or simple values other then those already in use). | |||
There was a problem hiding this comment.
I'm not sure what "already in use" would mean here...
There was a problem hiding this comment.
What I meant was "in the CRI grammar" -- but indeed those are not stand-in items, so maybe let's just drop that change. (Like, true and false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.