Fixes for Node 20 and latest Foundry support #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI failed on the latest push to master. This has two reasons:
[failure] The Foundry version is updated automatically and had a breaking change (see here). This is somewhat nice as it surfaces the fact that a test wasn't actually working as expected (because of a Foundry bug though).
[failure] The latest version of Node isn't compatible with the pinned package in our artifact generation procedure. I just pinned the Node version as well because I hope we're going to remove Hardhat artifact generation eventually anyway.
(I tried to update Hardhat to v2.17.0 (the earliest that supports Node 20) but I got another error (
HardhatError: HH502: Couldn't download compiler version list. Please check your internet connection and try again) which would have taken too much time to debug compared to trying to remove Hardhat in the first place.How to test
I released a tag to test artifact generation. The result can be found here (the tag will be deleted once the PR is merged), note that CI is successful.