Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid looking up 0x000 tx_hash (#2358)
# Description While the logic introduced in #2123 is sound the concern brought up by Dusan [here](#2123 (comment)) caused issues down the line. Specifically looking up the `0x000` tx_hash will always fail and would get logged as an error in the node proxy which surfaced [here](cowprotocol/infrastructure#1062 (comment)) Over all it's probably best to avoid issuing requests we know will fail even it the system is able to handle an error on those. # Changes Make `InFlightOrders` optional and don't fetch the tx_receipt when it has not been initialized yet. I decided to use `tokio::sync::Mutex` instead of `std::sync::Mutex` because calling a future while holding the lock made the code cleaner and since there is no contention on the lock due to the (currently) sequential nature of auctioneering holding the lock while fetching the tx receipt is not an issue.
- Loading branch information