Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Eliminate the order class in post order #2469

Closed
m-lord-renkse opened this issue Mar 5, 2024 · 1 comment
Closed

chore: Eliminate the order class in post order #2469

m-lord-renkse opened this issue Mar 5, 2024 · 1 comment
Assignees
@m-lord-renkse

Comments

@m-lord-renkse
Copy link
Contributor

Background

Since all the orders are limit orders, eliminate the order class from the post order.

Keep the order class in the database as an internal class with: limit and market. By doing this, we can easily count the number of real limit orders in order to limit the number of orders per user.

Details

It has to be done:

  • remove the order class in post order
  • classify properly internally if an order is market or limit
  • eliminate liquidity class order from the database (migration needed to move them as limit order)
  • change the way we count of "in-market` order to use the database class

Acceptance criteria

The changes are backwards compatible in behavior, but the API contract is changed. All the current tests must pass.
@m-lord-renkse m-lord-renkse self-assigned this Mar 5, 2024
This was referenced Mar 5, 2024
Merged
Merged
m-lord-renkse added a commit that referenced this issue Mar 5, 2024
@m-lord-renkse
Hotfix: Make OrderWithQuote as inner join in order not to get nullabl…
e7fe5bc 
…e quotes (#2477)

# Description
Do an `inner join` instead of `left join` in order not to have nullable
quotes in case they do not exist.

This query will be removed with
#2469

# Changes
Do an `inner join` instead of `left join` in order not to have nullable
quotes in case they do not exist. This way it does not error in case of
missing quote (it won't be counted, as it is a liquidity order anyway).

## How to test
1. CI
2. e2e
m-lord-renkse added a commit that referenced this issue Mar 7, 2024
@m-lord-renkse
Eliminate the order class in post order #2469
c5f119c
@m-lord-renkse m-lord-renkse mentioned this issue Mar 7, 2024
Closed
m-lord-renkse added a commit that referenced this issue Mar 7, 2024
@m-lord-renkse
Eliminate the order class in post order #2469
43ab2cf
m-lord-renkse added a commit that referenced this issue Mar 7, 2024
@m-lord-renkse
Eliminate the order class in post order #2469
a442095
m-lord-renkse added a commit that referenced this issue Mar 7, 2024
@m-lord-renkse
Eliminate the order class in post order #2469
fa01a67
m-lord-renkse added a commit that referenced this issue Mar 7, 2024
@m-lord-renkse
Eliminate the order class in post order #2469
4c1ab36
m-lord-renkse added a commit that referenced this issue Mar 7, 2024
@m-lord-renkse
Eliminate the order class in post order #2469
e10f6a4
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-lord-renkse m-lord-renkse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft: Eliminate the order class in post order #2469 cowprotocol/services
1 participant
@m-lord-renkse