Hotfix: Make OrderWithQuote as inner join in order not to get nullable quotes #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
force-pushed
the
hotfix-make-order-with-quotes-as-optional
branch
2 times, most recently
from
d5f0180 to
b458238
Compare
m-lord-renkse
changed the title
m-lord-renkse
force-pushed
the
hotfix-make-order-with-quotes-as-optional
branch
from
b458238 to
dcd7940
Compare
MartinquaXD
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do an
inner joininstead ofleft joinin order not to have nullable quotes in case they do not exist.This query will be removed with #2469
Changes
Do an
inner joininstead ofleft joinin order not to have nullable quotes in case they do not exist. This way it does not error in case of missing quote (it won't be counted, as it is a liquidity order anyway).How to test