Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove Error::ProtocolFeeOnStaticOrder #2507

Open
sunce86 opened this issue Mar 8, 2024 · 6 comments
Open

chore: Remove Error::ProtocolFeeOnStaticOrder #2507

sunce86 opened this issue Mar 8, 2024 · 6 comments

Comments

@sunce86
Copy link
Contributor

sunce86 commented Mar 8, 2024

Background

This error should not happen after CIP38.

This removal should trigger dependent cleanup in the solvers interface (making "fee" non-optional)
@sunce86 sunce86 mentioned this issue Mar 11, 2024
Merged
5 tasks
@sunce86
Copy link
Contributor Author

sunce86 commented Mar 30, 2024

Dependent on #2543

@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jun 12, 2024
@fleupold fleupold removed the stale label Jun 12, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Aug 12, 2024
@sunce86 sunce86 removed the stale label Aug 12, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Oct 12, 2024
@sunce86 sunce86 removed the stale label Oct 14, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the Stale label Dec 15, 2024
@sunce86 sunce86 reopened this Dec 23, 2024
@sunce86 sunce86 removed the Stale label Dec 23, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Feb 22, 2025
@github-actions github-actions bot closed this as completed Mar 1, 2025
@m-lord-renkse m-lord-renkse reopened this Mar 3, 2025
@github-actions github-actions bot removed the stale label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fleupold @sunce86 @mfw78 @m-lord-renkse