Fee tests #2510
Merged
Fee tests #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Felix Leupold <felixleupold90@gmail.com>
Co-authored-by: Felix Leupold <felixleupold90@gmail.com>
fleupold
commented
Mar 11, 2024
crates/driver/src/tests/setup/mod.rs
Outdated
| "factor": factor | ||
| } | ||
| }), | ||
| pub mod fee { |
There was a problem hiding this comment.
I think this one needs a bit of clean up. Either revert or move this module into its own file please.
| async fn price_improvement_fee_sell_out_of_market_order() { | ||
| let fee_policy = Policy::PriceImprovement { | ||
| factor: 0.5, | ||
| max_volume_factor: 1.0, |
There was a problem hiding this comment.
Do we have any tests checking the max volume factor for this policy?
Co-authored-by: Felix Leupold <felixleupold90@gmail.com>
Co-authored-by: Felix Leupold <felixleupold90@gmail.com>
sunce86
approved these changes
Mar 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposal on how to improve the readability of #2467
It only implements two surplus and one price improvement test case as an example, the others still need to be converted.
Changes
quoted_orderamounts fromexecutionamounts. This makes it so that a test case can specify a concrete limit price (QuotedOrderscurrently always use the AMM to compute their buy amounts).in_given_outon pool to correctly compute the executed amounts for buy orders.TestCaseis easier to readHow to test
Driver tests
Fixes #2479